fix: Disable connection pool as workaround for async runtime hang #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
2 tasks
2 tasks
sundy-li
reviewed
Jul 26, 2022
| // Disable connection pool to address weird async runtime hang. | ||
| // | ||
| // ref: https://github.com/datafuselabs/opendal/issues/473 | ||
| .pool_max_idle_per_host(0) |
There was a problem hiding this comment.
Does it have performance issue if we turn off ?
There was a problem hiding this comment.
It does, but not very seriously.
Most object storage services (like AWS S3, OSS, COS) will use http/2, which has its own connection stream and doesn't need http/1.1's keep-alive.
There was a problem hiding this comment.
BTW, aws s3 always returns Connection: close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuanwo github@xuanwo.io
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Related to #473